The time it takes to get good at singing can vary greatly from person to person, as it depends on several factors such as your natural talent, the consistency of your practice, the quality of the instruction you receive, and your mental and physical health. With regular and effective practice, most people can see improvement in their singing abilities within a few months to a year. However, becoming an excellent singer may take several years of diligent practice and professional training. It’s important to remember that progress is often gradual and can be influenced by many factors, so staying patient and persistent with your practice is key.